stacks-network / sbtc

Repo containing sbtc
GNU General Public License v3.0
285 stars 9 forks source link

[Feature]: Prevent network interference between concurrent coordinators #465

Open netrome opened 2 months ago

netrome commented 2 months ago

Feature - Prevent network interference between concurrent coordinators

1. Description

In #313 the transaction coordinator functionality for coordinating signing rounds was implemented. However, this implementation is sensitive to multiple coordinators acting concurrently, as the coordinator assumes all WSTS messages on the network relates to it's own signing round.

To make the coordinator more robust, we should ensure the coordinator filters out any messages with another bitcoin chain tip than the one the coordinator is working on. We should also introduce a test case to verify that coordinators can operate concurrently on the same network.

2.1 Acceptance Criteria:

3. Related Issues and Pull Requests (optional):

313

netrome commented 2 months ago

Part of this is done in https://github.com/stacks-network/sbtc/pull/480, see comment https://github.com/stacks-network/sbtc/pull/480#discussion_r1742467926

aldur commented 1 month ago

@djordon reports that the code has been implemented but there is no test yet.