add check for CPU type and warning if running on an M1

stacks-network / stacks-blockchain-docker

Stacks-blockchain with API using docker compose

GNU General Public License v3.0

27 stars 37 forks source link

add check for CPU type and warning if running on an M1 #54

Closed dcsan closed 2 years ago

dcsan commented 2 years ago

closes #53

Use the following template to create your pull request

Description

add a warning if run on an M1 mac to prevent people wasting days when we know it doesn't work see #53 for thread example. only the startup script has a detect_device added

no code changes to main codecase just the shellscript warning and an ⚠️ in the README

Checklist

[NA] Code is commented where needed
[NA] Unit test coverage for new or modified code paths
[NA] npm run test passes. (cannot run anything on an M1)
[NA] Changelog is updated
[x] Tag 1 of @person1 or @person2. @wileyj ?

CLAassistant commented 2 years ago

All committers have signed the CLA.

dcsan commented 2 years ago

noticed I had committed with my fork URL, updated to this now:

➜  stacks-blockchain-docker git:(53-detect-mac-m1) ./manage.sh mainnet up
⚠️  WARNING
⚠️  MacOS M1 CPU detected - NOT recommended for this repo
⚠️  see README for details
⚠️  https://github.com/stacks-network/stacks-blockchain-docker#macos-with-an-m1-processor-is-not-recommended-for-this-repo
Press enter to continue anyway or Ctrl+C to exit^C

wileyj commented 2 years ago

noticed I had committed with my fork URL, updated to this now:

➜  stacks-blockchain-docker git:(53-detect-mac-m1) ./manage.sh mainnet up
⚠️  WARNING
⚠️  MacOS M1 CPU detected - NOT recommended for this repo
⚠️  see README for details
⚠️  https://github.com/stacks-network/stacks-blockchain-docker#macos-with-an-m1-processor-is-not-recommended-for-this-repo
Press enter to continue anyway or Ctrl+C to exit^C

excellent, i was going to fix that after the merge but thanks!