Open kantai opened 1 year ago
@wileyj
I agree, i had a similar issue trying to build for arm64 with musl... had to use an external dependency that could likewise be brittle. definitely will take a look at this
On Wed, Jul 20, 2022 at 12:03 Aaron Blankstein @.***> wrote:
@wileyj https://github.com/wileyj
— Reply to this email directly, view it on GitHub https://github.com/stacks-network/stacks-blockchain/issues/3208#issuecomment-1190646930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVXIHCLGJMW7TJTDBEN6GTVVBERFANCNFSM54EZI7HA . You are receiving this because you were mentioned.Message ID: @.***>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Not stale -- this still should be removed.
The build scripts currently use a release output from https://github.com/hirosystems/docker-osxcross-rust -- this works okay, but ultimately is pretty brittle if this repo ever wanted to update that dependency.
It would be better if that dependency at least had a build script in this repo (e.g., in
./build-scripts/osxcross-rust/..
) and published the tarball in stacks-network/stacks-blockchain rather than through the separate repo. Another potential option is to include that build in the repo's build pipeline, but because we don't expect that dependency to change often, it may be very wasteful.