search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3k stars 659 forks source link

[Stacks 2.1] burnchain op for `revoke-delegate-stx` #3529

Open friedger opened 1 year ago

friedger commented 1 year ago

Describe the bug When users delegate stx using burnchain operations they are not able to change the pool, the amount or the membership period.

Steps To Reproduce Try to revoke delegation using a burnchain operation, it is not possible

Expected behavior A burnchain operation exists that creates synthetic events and that revokes delegation

jcnelson commented 1 year ago

Hi @friedger,

Try to revoke delegation using a burnchain operation, it is not possible

Can you explain this a bit more? Is there a failed 2.1 Stacks transaction that tried to revoked delegation that I can look at in the explorer?

friedger commented 1 year ago

@jcnelson There is a burnchain op code definition for delegate-stx, but there is not for revoke-delegate-stx

friedger commented 1 year ago

I fear that the synthetic events for delegate-stx are not relevant if we don't have events for revoke-delegate-stx. @jcnelson

jcnelson commented 1 year ago

I thought the node already generated synthetic events for revoke-delegate-stx? If not, then it could be added without breaking consensus. CC @zone117x @pavitthrap

jcnelson commented 1 year ago

Temporarily assigning this to @zone117x so it has an owner. Please feel free to re-assign!

zone117x commented 1 year ago

I'm not going to be working on this area of the code, however, I'm happy to work on the API part of this. @pavitthrap I'm re-assigning to you since you helped with the last one of these.

wileyj commented 11 months ago

available in pox-3: https://github.com/stacks-network/stacks-blockchain/blob/master/src/chainstate/stacks/boot/pox-3.clar#L632

friedger commented 11 months ago

@wileyj this issue is about burn chain operation. Currently, it is not possible to revoke via a btc tx.