search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 667 forks source link

Broken test: tests::epoch_21::test_pox_reorg_flap_duel #3580

Open kantai opened 1 year ago

kantai commented 1 year ago

Describe the bug

This test, which I think exhibits some flakiness, is broken more often than not in CI, because it usually does not complete within 30 minutes.

jcnelson commented 1 year ago

However, it usually runs on the second attempt.

This is a torture test on the system's ability to survive multiple successive PoX reorgs, where two coalitions each reorg each others' anchor blocks. The test completes when the coalitions stop ignoring each other, and converge on the same chain history.

igorsyl commented 1 year ago

Should we tag tests that should be run as part of smoke test perhaps outside of CI?

kantai commented 1 year ago

This is a torture test on the system's ability to survive multiple successive PoX reorgs, where two coalitions each reorg each others' anchor blocks. The test completes when the coalitions stop ignoring each other, and converge on the same chain history.

That's fine, but we shouldn't have a test that fails more than half of its runs. One option is extending the timeout for tests, but how long is this test supposed to take?