search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 667 forks source link

Feat/wasm global variable error #4878

Closed csgui closed 3 months ago

csgui commented 3 months ago

This PR adds a generic wasm error for globals on clarity-wasm standard library.

New global variables will be added to the Standard.wat WebAssembly file. For instance, a new variable to handle runtime errors is under validation on this PR.

Thus, it makes sense to have a generic WASM error to avoid creating a new error type for each global added to the WebAssembly.

obycode commented 3 months ago

Please check these failing unit tests. Were they caused by this change?

csgui commented 3 months ago

Hey @obycode ! Thanks for the review.

It appears the failing unit tests were imported from the base branch feat/clarity-wasm-develop. And consequently, the failing mutants are due to these failed unit tests.

csgui commented 3 months ago

Merging. The failing tests will be fixed in the base branch.