search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3k stars 658 forks source link

Chore/port signer v1 tests #4903

Closed jferrant closed 17 hours ago

jferrant commented 4 days ago

Partially closes https://github.com/stacks-network/stacks-core/issues/4802 I only added the mine 2 nakamoto reward cycles test.

The block proposal test was essentially equivalent to miner_gather_signatures test.

The signer reboot test will not work as we do not read stackerdb for missed block proposals on reboot for v0. This does beg the question, should we? Or should signers just wait for a new block proposal from the miners? Should miners try resending their events? I lean toward just waiting and making sure that this timeout rollover works (I believe it is currently broken based on testnet)

kantai commented 3 days ago

Or should signers just wait for a new block proposal from the miners? Should miners try resending their events? I lean toward just waiting and making sure that this timeout rollover works (I believe it is currently broken based on testnet)

I agree with you-- I think just waiting for the next proposal makes the most sense.

jferrant commented 1 day ago

This LGTM, and the test is passing for me locally.

Interesting. it passes locally for me as well, but I am wary to merge this as I think this was a flakey test in v1 as well. Gonna look into further to see if I can replicate the CI issue/Aaron's issue.