feat: Neon mock miner replay - Githubissues

stacks-network / stacks-core

The Stacks blockchain implementation

https://docs.stacks.co

GNU General Public License v3.0

3.01k stars 671 forks source link

feat: Neon mock miner replay #5060

Closed jbencin closed 3 months ago

jbencin commented 3 months ago

Description

There are two parts to this PR:

Add new config option, node.mock_mining_output_dir, which causes mock miner to write mock mined blocks to files
Add subcommand to stacks-inspect, stacks-inspect replay-mock-mining, which will read mock mined blocks and validate them against chainstate

PR Status

Added integration test neon_integrations::replay_mock_miner() and it passes. Have not tested against mainnet yet

Should probably add some real transactions to integration test, right now it's only coinbases

Due to refactoring replay_block() for use in mock mining replay, I've re-tested stacks-inspect replay-block and confirmed it still works

Applicable issues

fixes #4986

Additional info (benefits, drawbacks, caveats)

I refactored code used by stacks-inspect replay-block so that could re-use it here
I also refactored and pulled some functions out of stackslib/src/main.rs and into stackslib/src/cli.rs so that they could be called from integration tests
The way stacks-inspect replay-block processes it's arguments has changed slightly, and it no longer automatically adds "mainnet/" (because it now supports testnet/devnet/etc.) into the chainstate path

Checklist

[x] Integration test for stacks-inspect replay-mock-mining
[x] Test stacks-inspect replay-block
[ ] Test stacks-inspect replay-mock-mining with mainnet mock miner and chainstate
[ ] Changelog is updated
[ ] Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
[x] New integration test(s) added to bitcoin-tests.yml

blockstack-devops commented 2 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.