CI Mutants: Action Membership Run

stacks-network / stacks-core

The Stacks blockchain implementation

https://docs.stacks.co

GNU General Public License v3.0

3.01k stars 667 forks source link

CI Mutants: Action Membership Run #5083

Closed ASuciuX closed 1 month ago

ASuciuX commented 1 month ago

This is the PR enabling the full manual dispatch of the mutants CI so that they could run for more than 6 hours. It has a custom action limiting the access to trigger that only to the wanted team.

This should be merged only after:

the Master PR is merged which enables a GUI button to trigger this and make it testable https://github.com/stacks-network/stacks-core/pull/5082
the composite action is merged and fully functional https://github.com/stacks-network/actions/pull/50

wileyj commented 1 month ago

waiting on successful run from changes in #5082 before merging this. changes appear fine

ASuciuX commented 1 month ago

added attribution membership action & format output in this PR https://github.com/stacks-network/actions/pull/51, but isn't a blocker for the current one
it passed default checks https://github.com/stacks-network/stacks-core/actions/runs/10423875818
it fails as expected if the user is not part of the team ( I updated it to check for devops team and I am not part of it ) https://github.com/stacks-network/stacks-core/actions/runs/10424084011

wileyj commented 1 month ago

changes after addressing comments from @obycode and the conditionals i recommended look good. However, i think these changes should also be merged into master else they won't take effect until the next time a release branch is merged there (it may be a few weeks at the earliest).

could you cherry-pick these commits in a new PR based off of master to override #5082 ?

otherwise, these changes look good to me

ASuciuX commented 1 month ago

could you cherry-pick these commits in a new PR based off of master to override #5082 ?

sure, https://github.com/stacks-network/stacks-core/pull/5100