Fix: Revert `BurnchainHeaderHash` serialization change - Githubissues

stacks-network / stacks-core

The Stacks blockchain implementation

https://docs.stacks.co

GNU General Public License v3.0

3.01k stars 667 forks source link

Fix: Revert `BurnchainHeaderHash` serialization change #5094

Closed jbencin closed 1 month ago

jbencin commented 1 month ago

Description

Revert change made in #4986 to BurnchainHeaderHash serialization

Applicable issues

fixes #5091

Additional info (benefits, drawbacks, caveats)

Checklist

[ ] Test coverage for new or modified code paths
[ ] Changelog is updated
[ ] Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
[ ] New clarity functions have corresponding PR in clarity-benchmarking repo
[ ] New integration test(s) added to bitcoin-tests.yml

obycode commented 1 month ago

Can you also open the issue about testing chainstate migration, so that we can track its progress?

wileyj commented 1 month ago

Confirmed this branch works with a local chainstate that was failing after commit 6937df50343cacf452f0fd41c2984b08b7ae9df0