stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 667 forks source link

fix: Use correct config opts in `stop_bitcoind()` #5099

Closed jbencin closed 1 month ago

jbencin commented 1 month ago

Description

Config options like rpc_port, username, password, etc. are not consistent between start_bitcoind() and stop_bitcoind(). In start_bitcoind(), these are taken from the config, while in stop_bitcoind() they are hard-coded, and only match if the default config for integration tests is used

I came across this while working on #5096. This wasn't causing the problem, but was obviously incorrect and should be fixed anyways