I really have no idea if these changes are correct...some insight would be nice. For some reason, sometimes this test has the first sortition has no tenure and as a result it fails at assert!(!expects_miner_2_to_be_valid, "If no blocks were produced in the tenure, it should be because miner 2 committed to a fork"); because the expects_miner_2_to_be_valid is hardcoded to true for the first pass of the loop. I do not know if the fact that the first sortition has no tenure is a bug or if this is a legitimate path and therefore the test just needs this bool fix that I added.
Similarly, I don't know why, but ther eis always a consensus hash now so the check on consensus_hash.is_none() always fails. I assume something has changed back end to ensure that there always is a conesnsus hash and that this is a valid fix, but again...this is a bit nebulous to me.
I really have no idea if these changes are correct...some insight would be nice. For some reason, sometimes this test has the first sortition has no tenure and as a result it fails at
assert!(!expects_miner_2_to_be_valid, "If no blocks were produced in the tenure, it should be because miner 2 committed to a fork");because the expects_miner_2_to_be_valid is hardcoded to true for the first pass of the loop. I do not know if the fact that the first sortition has no tenure is a bug or if this is a legitimate path and therefore the test just needs this bool fix that I added.Similarly, I don't know why, but ther eis always a consensus hash now so the check on consensus_hash.is_none() always fails. I assume something has changed back end to ensure that there always is a conesnsus hash and that this is a valid fix, but again...this is a bit nebulous to me.