search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 667 forks source link

fix: use permanent backoff when stacker set not found #5104

Closed hstove closed 1 week ago

hstove commented 1 month ago

When the signer fetches the stacker set for a cycle, and the response is "not found" (because there isn't a PoX anchor block yet), a "permanent" error is returned instead of "transient". This will exit the exponential backoff function that would previously retry this request until the max timeout (5 seconds) was reached.

jferrant commented 1 month ago

Will this cause issues in the prepare phase though when it has not yet been calculated? I see that the "tests::signer::v0::reloads_signer_set_in" test is failing now.

hstove commented 1 week ago

LGTM! I can't review as it's my PR, but thank you @kantai for fixing this!

kantai commented 1 week ago

Marking as "merge when ready" -- the failing tests all pass locally. Two of these flaky tests (which are already flaky in develop) I think I have fixes for, so will open a PR to fix them soon.