stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Add extensive test cases for possible "invalid" blocks #5136

Open janniks opened 2 months ago

janniks commented 2 months ago

Not all possible reasons for not being valid are tested currently. e.g. https://github.com/stacks-network/stacks-core/blob/2be69cbf744ac339476362a3fb281257c9e1bebc/testnet/stacks-node/src/tests/signer/v0.rs#L39

Create more tests.

Possible errors for ValidateRejectCode:

All functions that aren't yet tested are part of theimpl NakamotoBlockProposal.


To do: Construct bad block proposal and submit to the signers. See how the signers deal with it.