stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Fix race condition between a block proposal and block responses #5146

Open jferrant opened 2 months ago

jferrant commented 2 months ago

Currently signers will ignore any block responses received for a block proposal they have never seen. It would be better if block responses included the block being signed/rejected and the receiving signer immediately start processing the received block OR store these orphaned responses on the side and apply them after a block proposal arrives. This is not super important as the system will just propose a new block if not enough rejections/approvals arrive in time from the signers, but it may be worthwhile all the same.