search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

chore: avoid warning from duplicate block-commit #5165

Closed obycode closed 1 month ago

obycode commented 2 months ago

This change ended up being a lot larger than I'd hoped, but with a recent investigation into some networking failures when communicating with the bitcoin node, these warnings were annoying. I'm just trying to reduce false-positive warning logs.

The problematic case shows up like this in the logs before this change:

INFO [1725975417.732025] [testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs:1634] [miner-block-http://127.0.0.1:35738] Abort attempt to re-submit identical LeaderBlockCommit
WARN [1725975417.732029] [testnet/stacks-node/src/neon_node.rs:2759] [miner-block-http://127.0.0.1:35738] Relayer: Failed to submit Bitcoin transaction
obycode commented 2 months ago

Looks like some new integration test failures here. Let's not merge until they've been reviewed.

obycode commented 2 months ago

Another new kind of CI failure. @wileyj, have you ever seen this one?

Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: stacks-core-1c13216f40e101695442d889d53b65984c6d8e9c-cargo
wileyj commented 2 months ago

Another new kind of CI failure. @wileyj, have you ever seen this one?

Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: stacks-core-1c13216f40e101695442d889d53b65984c6d8e9c-cargo

it's more of a safety check to fail fast - the cache store has been pretty consistent, but it's just an http(s) download and can fail for random reasons.

if the cache buiild steps pass, the only reason this would trigger is if there was some network issue on the vm (there are other issues that could pop up from time to time - like the download not succeeding, or the extraction failing, but those produce different failures than you shared here).

looking over the tests, i see a lot passed so this was most likely transient - if you have a specific link to where you found that error i can look more, but as long as the workflows to build the cache complete successfully - a retry should get past that error.

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.