search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

[nakamoto] Bug in `/v2/neighbors` #5172

Closed diwakergupta closed 2 months ago

diwakergupta commented 2 months ago

Copying over from Nakamoto Slack, as reported by @jcnelson:

There's a bug in /v2/neighbors -- it's reporting all neighbors whose last-contact time is greater than self.connection_opts.max_neighbor_age (which is sometime in January 1970 if taken as an absolute UNIX timestamp), whereas the p2p interfaces all use get_epoch_time_secs() - self.connection_opts.max_neighbor_age (which is correct). self.connection_opts.max_neighbor_age is set to 3 days. Some addresses reported in /v2/neighbors may be dead

blockstack-devops commented 3 weeks ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.