stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Stackerdb fix: Delete stale slots from stackerdb during creation or reconfiguration #5178

Closed jferrant closed 2 months ago

jferrant commented 2 months ago

This was causing issues in the inventory sync of various nodes. They would be checking the sql database for the number of slots expected which would contain empty / stale slots from prior reward cycles causing them to reject the inbound stackerdb messages. This just deletes these unused slots on creation/reconfiguration.

EDIT: FIXING TESTS

jcnelson commented 2 months ago

I think this is a dup of this? https://github.com/stacks-network/stacks-core/pull/5152 Can you try it on your end to see if it works?

jferrant commented 2 months ago

I think this is a dup of this? #5152 Can you try it on your end to see if it works?

YOu are definitely right. I knew I had heard you mention something about this!

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.