search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Fix/5203 and 5204 #5208

Closed jcnelson closed 1 month ago

jcnelson commented 2 months ago

Delete NakamotoDownloadStateMachine::load_tenure_start_blocks(), and everything that depended on it.

This feature was an optimization brought about by the observation that the tenure-end block of tenure N would be the tenure-start block of tenure N+1, and an attempt was made to avoid extra network round-trips to fetch the tenure-start block twice. However, this approach lead to #5203 and #5204, the latter of which would be difficult to fix with confidence. So instead, I'm opting to delete this code and see how it goes. If it leads to unacceptable performance, we'll think of something then.

hstove commented 1 month ago

@obycode I've just ran regtest-env with this commit, and it's working well! Since this is p2p-related, that might not be important, but we might need to run this on one of the testnets if we wanted to test that out.

kantai commented 1 month ago

Both of the failed CI tests pass locally.

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.