search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

`miner_signature_hash` should include `pox_treatment` BitVec #5216

Closed hstove closed 1 month ago

hstove commented 1 month ago

When constructing miner_signature_hash for a Nakamoto block, the pox_treatment BitVec is not included. While this is included in signer_signature_hash, not including this in the miner's sighash can result in inconsistent blocks that signers are signing over.

jcnelson commented 1 month ago

I think this is intentional. The signers decide among themselves what the signer liveness bitvec should be, not the miner.

jcnelson commented 1 month ago

(cc @kantai)

blockstack-devops commented 3 weeks ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.