Ugly addition of a stop receiver channel to exit the signer runloop

stacks-network / stacks-core

The Stacks blockchain implementation

https://docs.stacks.co

GNU General Public License v3.0

3.01k stars 671 forks source link

Ugly addition of a stop receiver channel to exit the signer runloop #5222

Closed jferrant closed 1 month ago

jferrant commented 1 month ago

This is so ugly but I couldn't think of a better way to do this. I could of course just exit if it fails on retry and NOT store the block if it fails, but Jude specifically requested that the signer loop infinitely until the block is acknowledged by the node. It is probably not a bad idea to have a means to terminate the signer runloop anyway, but I can't stand how involved of a change this was XD

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.