fix: allow to get tenure-info for the latest block

stacks-network / stacks-core

The Stacks blockchain implementation

https://docs.stacks.co

GNU General Public License v3.0

3.01k stars 671 forks source link

fix: allow to get tenure-info for the latest block #5235

Closed hugocaillard closed 1 month ago

hugocaillard commented 1 month ago

Description

get-tenure-info? should be callable on the latest stacks-block

Applicable issues

fixes: #5228

Additional info (benefits, drawbacks, caveats)

Checklist

[x] Test coverage for new or modified code paths
[ ] Changelog is updated
[ ] Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
[ ] New clarity functions have corresponding PR in clarity-benchmarking repo
[ ] New integration test(s) added to bitcoin-tests.yml

obycode commented 1 month ago

Looks like the change is not so simple. This is hitting:

FATAL: no burnchain block height found for Stacks block b40ffa12cd6cdec17a0cf0231bffb40d9271c319a5113e88792a3488765e6c6b

obycode commented 1 month ago

Ok, so I think we need some more significant changes here to make this work. We can't pull this info from the headers db, because it hasn't been set yet for the current block if it is the tenure change block. This info is all set after the tenure change block is processed. For all other blocks, it looks up the tenure change block, then gets its entry. @kantai, might need your help on this.

kantai commented 1 month ago

Ok, so I think we need some more significant changes here to make this work. We can't pull this info from the headers db, because it hasn't been set yet for the current block if it is the tenure change block. This info is all set after the tenure change block is processed. For all other blocks, it looks up the tenure change block, then gets its entry. @kantai, might need your help on this.

My current thinking on this is that the property we should have for fetching stacks block based metadata is that you can only fetch metadata for stacks blocks less than the current block. That is the property that's currently implemented, and its maybe a little surprising for the first block in a tenure, but its actually a consistent policy across both get-tenure-info and get-stacks-block-info, so I'm kind of inclined to say that we should just document this a bit more explicitly rather than changing it.

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.