stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Fix multiple_miners* tests #5237

Closed jferrant closed 1 month ago

jferrant commented 1 month ago

Fixes both multiple_miners and multiple_miners_with_nakamoto_blocks tests.

hstove commented 1 month ago

Unfortunately it looks like multiple_miners is failing on c60e4a6

jferrant commented 1 month ago

Unfortunately it looks like multiple_miners is failing on c60e4a6

NEIN! haha taking another wack at it.

hstove commented 1 month ago

Looks like multiple_miners is passing now!

jferrant commented 1 month ago

Looks like multiple_miners is passing now!

Yes i think it might have been failing before with that weird timeout with no logging thing that seems to randomly afflict tests. :/

kantai commented 1 month ago

This LGTM -- my only comment is that you should use the approach from https://github.com/stacks-network/stacks-core/commit/6a3746c9f6ca4edec8e9ce66efdbf074e87f5615 in the rejection tracking.

obycode commented 1 month ago

This fixes tests::signer::v0::partial_tenure_fork too!

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.