search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Fix/5249 #5253

Closed jcnelson closed 1 month ago

jcnelson commented 1 month ago

Fixes #5249. The bug was that we were not invalidating cached negatives (i.e. marking the absence of a tenure) when the Nakamoto tip advanced. As a result, tenures that did not yet exist as of the Nakamoto tip when the cache was initially populated, but later came into existence, would never be reported in the inventory vector.

Leaving this as a draft until I can add some more test coverage.

jcnelson commented 1 month ago

Don't let the line count scare you. The fix is very small; over 90% of the new lines are tests.

jferrant commented 1 month ago

I think this is okay, but i have never seen tests::nakamoto_integrations::continue_tenure_extend fail before so wonder if its an issue with this branch...EDIT: I ran it locally in develop and your branch and both pass so I guess this is just a new flakey test. XD

hstove commented 1 month ago

Confirmed that running this on my Nakamoto Testnet node has fixed the issue of not being able to catch all the way back up to the tip

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.