search

stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 671 forks source link

Chore: remove infinite loop in signer during tests #5259

Closed kantai closed 1 month ago

kantai commented 1 month ago

Description

This PR removes an infinite loop in the signer when cfg!(test) is active. The rationale for this is that signer integration tests often stop the stacks-node threads (via panic, asserts, etc.) on failure before they stop the signer threads. I think this leads to a situation where a test failure loops indefinitely, which in the CI prevents logs from appearing, making diagnosing CI failures and flaky tests very difficult.

This PR also removes the first block push invocation -- if the first push in the loop succeeds, there's no need to repush.

blockstack-devops commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.