stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 672 forks source link

Adjust signer to send BlockResponse even after block is marked as GloballyAccepted (or rejected) #5451

Closed hstove closed 1 day ago

hstove commented 1 week ago

When a signer gets a block validation response back from its node, it first checks if it has locally marked the block as GloballyAccepted or GloballyRejected. If this is the case, the signer doesn't broadcast a BlockResponse.

It would be better for the signer to still broadcast a block response, for a few reasons:

Relevant code:

https://github.com/stacks-network/stacks-core/blob/db35bfec877c368e1ccb8640dccc4bfc3430e914/stacks-signer/src/v0/signer.rs#L497-L509