stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 672 forks source link

DRAFT - POC for managing version across binaries #5469

Open cipherzzz opened 6 days ago

cipherzzz commented 6 days ago

This pull request introduces several changes to the stacks-common and stacks-signer modules to enhance version handling and improve code organization. The most important changes include the addition of a new versions module, updates to the Cargo.toml file, and modifications to the build.rs file to handle version information more efficiently.

Enhancements to version handling:

Code organization improvements:

Updates to stacks-signer:

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

cipherzzz commented 6 days ago

@wileyj @hstove

# cd stacks-signer dir
STACKS_SIGNER_VERSION=3.2.1.0 cargo build

# cd targets/debug
./stacks-signer --version
hstove commented 5 days ago

Nice work on opening your first PR btw! 👊

cipherzzz commented 3 days ago

@hstove @wileyj - It looks like the heavy lifting is already done in #5399 . So, the remaining work is just to

hstove commented 3 days ago

@cipherzzz yep!