Open cipherzzz opened 6 days ago
@wileyj @hstove
# cd stacks-signer dir
STACKS_SIGNER_VERSION=3.2.1.0 cargo build
# cd targets/debug
./stacks-signer --version
Nice work on opening your first PR btw! 👊
@hstove @wileyj - It looks like the heavy lifting is already done in #5399 . So, the remaining work is just to
version
to the remaining binaries
stacks-node
version for these remaining cli
versions - and keep the signer version separate? @cipherzzz yep!
This pull request introduces several changes to the
stacks-common
andstacks-signer
modules to enhance version handling and improve code organization. The most important changes include the addition of a newversions
module, updates to theCargo.toml
file, and modifications to thebuild.rs
file to handle version information more efficiently.Enhancements to version handling:
stacks-common/src/util/versions.rs
: Added a newversions
module that includes functions to retrieve and format build versions for different binaries.stacks-common/build.rs
: Introduced a newVersions
struct and functions to read version information from aversions.yaml
file and override it with environment variables if they exist.Code organization improvements:
stacks-common/Cargo.toml
: Reformatted theauthors
andkeywords
fields for better readability and added new dependencies forserde
andserde_yaml
. [1] [2] [3]stacks-common/src/util/mod.rs
: Added the newly createdversions
module to the list of public modules.Updates to
stacks-signer
:stacks-signer/src/libsigner.rs
: Replaced the manual version string construction with the newget_long_version
function from theversions
module.stacks-signer/src/main.rs
: Integrated theget_build_version
function from theversions
module to retrieve build version information.Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml