stacks-network / stacks

Overview of Bitcoin's Stacks layer.
https://www.stacks.co/
2.03k stars 243 forks source link

Gina abrams patch 2 #375

Closed ghost closed 6 years ago

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

:white_check_mark: jackzampolin
:x: pstan26
:x: shea256
:x: GinaAbrams
:x: guylepage3
You have signed the CLA already but the status is still pending? Let us recheck it.

jackzampolin commented 6 years ago

This looks like you are dragging some commits in and it needs to be rebased. Can you please rebase this PR @sheikhing ?

ghost commented 6 years ago

Hi Jack,

Sorry I am not sure what this means?

On Wed, Jan 10, 2018 at 3:35 PM, Jack Zampolin notifications@github.com wrote:

This looks like you are dragging some commits in and it needs to be rebased. Can you please rebase this PR @sheikhing https://github.com/sheikhing ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blockstack/blockstack/pull/375#issuecomment-356773982, or mute the thread https://github.com/notifications/unsubscribe-auth/AgrEpCo4a9qhbCVj2e-wGGziCV8Ewmhhks5tJUlGgaJpZM4Q1sUK .

jackzampolin commented 6 years ago

@sheikhing Do you see up at the top where this Pull Request has a bunch of changes from other people included? Try pulling down the repo, creating your own branch from master. Then you can make your changes and open the pull request. It looks like this particular pull is branched from GinaAbrams-patch-1 for some reason.

ghost commented 6 years ago

Hi Jack,

Can you give me a call - 773 208 7677?

On Thu, Jan 11, 2018 at 2:08 PM, Jack Zampolin notifications@github.com wrote:

@sheikhing https://github.com/sheikhing Do you see up at the top where this Pull Request has a bunch of changes from other people included? Try pulling down the repo, creating your own branch from master. Then you can make your changes and open the pull request. It looks like this particular pull is branched from GinaAbrams-patch-1 for some reason.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blockstack/blockstack/pull/375#issuecomment-357077389, or mute the thread https://github.com/notifications/unsubscribe-auth/AgrEpC7Y7yHjphJvwUGzucyNXr48vVPjks5tJoZrgaJpZM4Q1sUK .

jackzampolin commented 6 years ago

I think we can resolve this here. Can you explain what you are trying to do with this PR?

ghost commented 6 years ago

Sorry I was just messing around - I've never used GitHub so please feel free to delete / remove me from this.

On Thu, Jan 11, 2018 at 2:14 PM, Jack Zampolin notifications@github.com wrote:

I think we can resolve this here. Can you explain what you are trying to do with this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blockstack/blockstack/pull/375#issuecomment-357078778, or mute the thread https://github.com/notifications/unsubscribe-auth/AgrEpJMkBepu4DWjeaGmSiFhOeCZL49Fks5tJoevgaJpZM4Q1sUK .

jackzampolin commented 6 years ago

For sure! Thanks for the heads up! Closing!