Closed wileyj closed 1 year ago
If the editors CABs feel confident then you can also use the PR to update the status to Recommended. But ideally we want a separate PR from editors to bring it to Accepted.
If the editors CABs feel confident then you can also use the PR to update the status to Recommended. But ideally we want a separate PR from editors to bring it to Accepted.
This makes sense, on SIP-022 we settled on a nice flow for each group to interact with the SIP flow here.
Process so far as it relates to GitHub:
Accepted
through a PRRecommended
through a PRActivation-in-Progress
(also want to update the readme here with new SIP number)Noting there's a GitHub label for each status change as well.
cc @Hero-Gamer so we don't lose this info :slightly_smiling_face:
Thanks @whoabuddy. That sounds great. Right now SIP-023 has a draft status and CAB sign-offs on the main branch. Can we get editors to open a PR to prepend to the sign-off and change the status to Accepted
? Perhaps we can move to Recommend
on the same branch and reference this PR. I'm ready to sign off and change the status to Activation-in-Progress
once the aforementioned is done.
@MarvinJanssen passed this along to @Hero-Gamer to see who in the SIP editor group would feel comfortable doing so!
SIP Editor @rafaelcr will be submitting PR to change status to Accepted from Draft. Anything please ask him for this time round!
Adding signoff line to SIP-023