Now that we have more and more people looking at SIPs, we need a consistent workflow that's easy to use but adheres to SIP-000.
Since GitHub is the main medium we're using for the SIPs, I propose the following approach:
New SIP is created in Draft status via a PR
Once ready, request review from SIP Editors, who have at least one person with access to this GitHub repo that can be tagged (s/o to @rafaelcr)
SIP Editors will provide feedback until SIP is ready, then review/approve the PR, then make a commit to the PR adding their sign-off and updating the status to Accepted
Request reviews from relevant CABs, who also have at least one person with access (gov: @whoabuddy, tech: @obycode)
CAB will provide feedback and add minutes in a separate PR, then if approved, review/approve the PR, and add their sign-off. Last CAB to add sign-off also updates status to Recommended
Request review from Steering Committee (likely @jcnelson) and they can review/approve the PR, add their sign-off (is there a spot for this?), and update status to Activation-in-Progress and the README.
At that point we should probably merge it as it would update the README on the main branch, which shows both activation-in-progress and ratified SIPs.
Then a separate PR could be created (by SC, or maybe by others in the groups above) that changes the status to Ratified and updates the README once it's finalized.
Another way to look at this:
a PR gets created for the SIP, which tracks it from Draft -> Accepted -> Recommended -> Activation-in-Progress
includes comments/feedback from SIP editors
includes approval/sign-off from CABs
includes approval/sign-off from SC
merged once it reaches Activation-in-Progress
a PR gets created for each CABs meeting minutes
a PR gets created to update the status from Activation-in-Progress to Ratified
Curious if others have thoughts on this, the SIPs below have parts of the process in place, and once we settle on a structure we can document it either through a SIP, somewhere in this repo as a doc, or both.
Now that we have more and more people looking at SIPs, we need a consistent workflow that's easy to use but adheres to SIP-000.
Since GitHub is the main medium we're using for the SIPs, I propose the following approach:
Draftstatus via a PRAcceptedRecommendedActivation-in-Progressand the README.At that point we should probably merge it as it would update the README on the main branch, which shows both activation-in-progress and ratified SIPs.
Then a separate PR could be created (by SC, or maybe by others in the groups above) that changes the status to
Ratifiedand updates the README once it's finalized.Another way to look at this:
Draft->Accepted->Recommended->Activation-in-ProgressActivation-in-ProgressActivation-in-ProgresstoRatifiedCurious if others have thoughts on this, the SIPs below have parts of the process in place, and once we settle on a structure we can document it either through a SIP, somewhere in this repo as a doc, or both.
141
131
127