Closed lgalabru closed 3 years ago
@jcnelson this PR is a bit off because the SIP repo branch for SIP-10
does not include the latest commits from my PR, and so this PR does not include those commits. I'm happy with merging this, but we should first sync my branch, then fix the one typo here, and then we can merge
Is this ball in my court, @hstove's, or @jcnelson's?
Either @hstove or @lgalabru -- it's the SIP authors' job to get the SIP into the right format.
Maybe a miscommunication - what I meant is that this PR is trying to merge into the hstove-feat/sip-10-ft
branch, but the open PR (#5 ) has more recent commits than that branch. So this PR is not quite in sync with the latest of my PR.
Either way, it's all good - I've cherry-picked and pushed @lgalabru's commits to #5. So, I think we can close this PR!
This PR is a proposal for augmenting the transfer function with an optional memo field. I'd also recommend going with a naming more explicit for this trait - something like
sip-010-trait
would be more descriptive: this trait is the first, but we will probably see other kind of fungible token in the future.