stacksgov / sips

Community-submitted Stacks Improvement Proposals (SIPs)
131 stars 80 forks source link

SIP-005 - a couple of issues #39

Closed faried closed 2 years ago

faried commented 2 years ago

The prefix byte for standard and contract post-condition principals does not appear to be documented.

Standard principals:

Contract principals:

For Transaction Signing and Verifying the spec says

If this is a single-signature spending condition, then set the fee rate and nonce to 0, set the public key encoding byte to Compressed, and set the signature bytes to 0 (note that the address is preserved).

I started to implement my versions of verifyBegin() and verifyOrigin() (as in @stacks/transactions) and noticed that the public key encoding byte is copied for standard single-sig transactions, not set to compressed.

jcnelson commented 2 years ago

Hey, thanks for letting us know! Will fix.