stacksgov / sips

Community-submitted Stacks Improvement Proposals (SIPs)
130 stars 80 forks source link

SIP-015: Stacks Upgrade of Proof-of-Transfer and Clarity #95

Closed jcnelson closed 1 year ago

jcnelson commented 1 year ago

This PR supersedes #53 and contains the SIP for activating Stacks 2.1.

jcnelson commented 1 year ago

Tagging @obycode as a reviewer (it's not letting me do in the "reviewers" section it for some reason).

janniks commented 1 year ago

Added some comments that may have been addressed in some discussions, but would be nice to have as part of the SIP text.

friedger commented 1 year ago

It looks like the stacking amount was removed in pox2. Is that a bug or a feature that should be mentioned here? https://github.com/stacks-network/stacks-blockchain/issues/3436

jcnelson commented 1 year ago

Just an update on this -- we will merge this once 2.1 activates on mainnet.

friedger commented 1 year ago

v1_unlock_height is supposed to be set before the SIP activates. On mainnet, v1_unlock_height is apparently set to bitcoin block height 781551. I couldn't find any code confirming that.

Hero-Gamer commented 1 year ago

Hi SC members, @jcnelson @MarvinJanssen @GinaAbrams According to SIP-000: https://github.com/stacksgov/sips/blob/main/sips/sip-000/sip-000-stacks-improvement-proposal-process.md

image

Understand all been the SIPs in-activation been reviewed/approved at SC level, however would it worth documenting the Votes from the SC members somewhere on Github for transparency like what the CABs did like this? https://github.com/stacksgov/sips/tree/main/considerations/minutes

Same goes for SIP-020, SIP-018, SIP-019