Re-export StackFrame type for backwards compatibility - Githubissues

stacktracejs / error-stack-parser

Extract meaning from JS Errors

https://www.stacktracejs.com/#!/docs/error-stack-parser

MIT License

450 stars 52 forks source link

Re-export StackFrame type for backwards compatibility #72

Closed andersk closed 2 years ago

andersk commented 2 years ago

Description

2.0.7 removed a mis-matching export of StackFrame (#54), but some users were relying on it. Re-export the correct one.

Motivation and Context

https://github.com/stacktracejs/error-stack-parser/pull/54#commitcomment-66531802

How Has This Been Tested?

tsc error-stack-parser.d.ts

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
- (You removed jscs in f5184d7e89fcbdd54f06c4a8153010c0d1489ef5.)
[x] npm test passes without errors
[x] I have read the contribution guidelines
- (FYI, this is a broken link when you actually open a PR.)
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes

eriwen commented 2 years ago

Thanks for the PR @andersk!

I'd like to prevent these kinds of regressions using automated checks. Do you have any recommendations (GitHub actions or npm scripts) to do this?

andersk commented 2 years ago

@RenateM It sounds like you have a very old version of TypeScript. Make sure you’ve upgraded to at least 3.8 (latest: 4.7.3).