search

stackvana / hook.io

Open-Source Microservice Hosting Platform
https://hook.io
Other
1.26k stars 117 forks source link

JSHINT bankruptcy / Add .jshint file and clean-up codebase #207

Open Marak opened 8 years ago

Marak commented 8 years ago

The entire codebase needs a JSHINT review and cleaning.

This could be a good opportunity for someone new to the project to help contribute.

First pull request would be adding the jshint configuration and documentation, then performing a lint on one small file. Once we have this in place, we can begin linting every file.

Do not want a waterfalled lint of the entire system. Due to the cross-cutting nature of changes I'd like to review changes to every file as an individual commit.

sbruchmann commented 8 years ago

Is JSHINT a strict requirement for hook.io? If not, I’d like to vote for eslint.

Marak commented 8 years ago

@sbruchmann -

I'd prefer to stick with what I know works, but it's really up to whoever is willing to update the codebase. I don't know if we need any of the advanced features eslint provides over jshint?

If you can provide a PR will eslint configuration and default settings I will review it for possible usage.