search

stackvana / hook.io

Open-Source Microservice Hosting Platform
https://hook.io
Other
1.26k stars 117 forks source link

stderr no longer being sent to client when hook errors #293

Closed Marak closed 6 years ago

Marak commented 6 years ago

With the latest version of microcule, we've lost a bit of feedback when using the code gateway or running hooks that error.

Currently all errors are being sent to the logs, which is not ideal when debugging or developing services.

I've got a patch working locally that restores functionality of sending stderr to stdout response, but only if the service exits with an non-zero error code ( meaning the service errored ). This should make the developer experience much better. I've also added an option to microcule for making the ability to send stderr to the response optional.

High priority.

Marak commented 6 years ago

We pushed out a patch this morning to address the issue, but ran into some production issues and had to comment out one of the stderr output conditions.

Going to investigate and see what can be done. Upgrading from node v6 to node v8 might fix the issue.

Marak commented 6 years ago

Made another patch to microcule and everything seems to be working as expected.

Errors should be sent back to the client for non-zero exit codes. Works well for debugging / developing services.

Closing for now.