search

stackworx / formik-mui

Bindings for using Formik with Material-UI
https://stackworx.github.io/formik-mui
MIT License
968 stars 141 forks source link

support for @testing-library/react with Select #118

Open ian5484 opened 4 years ago

ian5484 commented 4 years ago

I am having trouble triggering the onChange or setValues when dispatching a change event when using a Select. Would you be able to provide an example for this? I have a suspicion this might be a bug.

Here is what I have been trying:

fireEvent.change(container.querySelector('input[name="phoneNumber"]'), { target: { value: "18005551234" } });

This works for basic fields like TextField but I think some of the onChange shims might be interfering the dispatched change event for Select.

The values prop in the Formik render scope never updates if the input is from the Select, however immediately updates if it's a TextField.

cliedeman commented 4 years ago

@testing-library/react has been integrated into the project but not all the components have the better tests yet.

pskfry commented 4 years ago

in tests i typically mock all material ui components. do you have a reason for not doing so here? it is much easier just to replace all material ui inputs with native html tags. i think you can trust material-ui's internal unit tests to verify that a select input works the way it's supposed to.