search

stackxyz / stackeye

StackEye is a chrome extension which lets user watch questions on stackoverflow and other stackexchange sites.StackEye notifies the user about any new comment/answer on watched questions.
84 stars 27 forks source link

Clicking on Notification is not clearing the notification #56

Closed sachinjain024 closed 5 years ago

sachinjain024 commented 5 years ago
screenshot 2019-02-13 15 08 15

This is a regression and got introduced with latest release in v19.2.12

sachinjain024 commented 5 years ago

Fixed this issue and released v19.2.13. Closing this issue.

seanf commented 5 years ago

@sachinjain024 You know, the new TypeScript setup would have caught that (just tried it). :-) You just need to run npm run watch (assuming your IDE isn't showing TypeScript errors already).

sachinjain024 commented 5 years ago

Thanks, Sean for informing this. I will try this out and thanks for motivating me to look for learning Typescript.

On Wed, Feb 13, 2019 at 4:54 PM Sean Flanigan notifications@github.com wrote:

@sachinjain024 https://github.com/sachinjain024 You know, the new TypeScript setup would have caught that (just tried it). :-) You just need to run npm run watch (assuming your IDE isn't showing TypeScript errors already).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sachinjain024/stackeye/issues/56#issuecomment-463162999, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9uL9rjH2Rgygkabt8xRq_4_WbVvmudks5vM_XVgaJpZM4a4_GB .