search

stactools-packages / goes-glm

stactools package for the Geostationary Lightning Mapper (GLM) on the GOES satellites
Other
2 stars 1 forks source link

Update version number to v0.2.0, goes extension and other minor updates #20

Closed m-mohr closed 1 year ago

m-mohr commented 1 year ago

Release v0.2.0 and activate the GOES extension (fixes #12 once @gadomski commented on it and we released it)

gadomski commented 1 year ago

I took a look over the GOES extension and opened one issue, once that's resolved I'd say the extension looks good, though it'd be good to get @pjhartzell's input as well.

pjhartzell commented 1 year ago

Some comments (all related to the goes extension):

m-mohr commented 1 year ago
  • Add Test as an option for goes:orbital-slot?

It's a bit weird to add Test as an orbital slot, but yeah it's probably the only option we have? Is it the same for ABI? How is ABI data handled before the drift?

  • Uses kebab-case; is snake_case standard/preferable?

For the values? Doesn't really matter, I think kebab in values is a bit more common but we are free to define that. For keys/property names definitively snake case.

  • Is there a branch or repo I'm not seeing? The json schema looks like it is still boilerplate from the template.

No, I just got feedback from @gadomski yesterday, so I still need to work through the goes extension repo now.

pjhartzell commented 1 year ago

It's a bit weird to add Test as an orbital slot, but yeah it's probably the only option we have? Is it the same for ABI? How is ABI data handled before the drift?

ABI Items do not currently include the orbital slot. And the bbox info is grabbed from the source file (rather than a defined constant value). So the Test slot appears to be handled.

For the values? Doesn't really matter, I think kebab in values is a bit more common but we are free to define that. For keys/property names definitively snake case.

OK, just curious if there was a recommendation. I looked around and saw instances of both.

No, I just got feedback from @gadomski yesterday, so I still need to work through the goes extension repo now.

Sounds good. 👍

m-mohr commented 1 year ago

I've released the goes extension and applied all necessary updates. The tests seem to all succeed now (at least locally, CI still running), too. I think we are ready to merge and re-release as v0.2.0. @pjhartzell If there's still something wrong with it, just let me know and I can take it on after the weekend. Or feel free to make updates and re-release :-)