stactools-packages / landsat

stactools package for working with LANDSAT data
Other
4 stars 6 forks source link

fixes issue 1: Add logic to utilize MTL file in landsat subpackage #16

Closed pjhartzell closed 2 years ago

pjhartzell commented 2 years ago

No plans to create STAC exclusively from MTL files, so remove that functionality.

pjhartzell commented 2 years ago

Is there any risk that these functions are being used by a downstream that we don't know about?

No idea. But if you look at the primary function that is being removed, transform_mtl_to_stac, it doesn't contain the basic extensions you need, e.g., proj, eo, or view, let alone the landsat extension. So if you're using it, you are doing some decent work after the fact to update the Items. Also, along the same thought, the test test_transform_mtl just verifies that the Items it creates fail validation...

If so, deprecation might be the more appropriate route.

I'm not clear on this, so maybe we can discuss offline.