stactools-packages / naip

stactools package for working with the USDA's National Agriculture Imagery Program data
Other
7 stars 3 forks source link

replace the grid extension in this package with the one in pystac #37

Closed philvarner closed 1 year ago

philvarner commented 1 year ago

Related Issue(s):

Proposed Changes:

  1. replace the the GridExtension class in this package with the GridExtension class in pystac

PR Checklist:

philvarner commented 1 year ago

Even though it's not required b/c of transitive dependencies, we should explicitly floor pystac >= 1.5 in the setup.cfg for this package, to be explicit that we need pystac and the grid extension (which was added in v1.5.0).

stactools >= 0.4.3 requires pystac[validation] >= 1.6.1

philvarner commented 1 year ago

added pystac explicitly

gadomski commented 1 year ago

stactools >= 0.4.3 requires pystac[validation] >= 1.6.1

Right, but since we explicitly import and use pystac it (IMO) is best practice to add pystac to install_requires as well. I recognize this practice isn't followed everywhere, but given an opportunity to do it, we should (again, IMO).

philvarner commented 1 year ago

stactools >= 0.4.3 requires pystac[validation] >= 1.6.1

Right, but since we explicitly import and use pystac it (IMO) is best practice to add pystac to install_requires as well. I recognize this practice isn't followed everywhere, but given an opportunity to do it, we should (again, IMO).

I completely agree with that, I didn't mean to imply we shouldn't, I was just documenting what the requirement was