Closed philvarner closed 1 year ago
Even though it's not required b/c of transitive dependencies, we should explicitly floor
pystac >= 1.5
in thesetup.cfg
for this package, to be explicit that we needpystac
and the grid extension (which was added in v1.5.0).
stactools >= 0.4.3 requires pystac[validation] >= 1.6.1
added pystac explicitly
stactools >= 0.4.3 requires pystac[validation] >= 1.6.1
Right, but since we explicitly import and use pystac
it (IMO) is best practice to add pystac
to install_requires
as well. I recognize this practice isn't followed everywhere, but given an opportunity to do it, we should (again, IMO).
stactools >= 0.4.3 requires pystac[validation] >= 1.6.1
Right, but since we explicitly import and use
pystac
it (IMO) is best practice to addpystac
toinstall_requires
as well. I recognize this practice isn't followed everywhere, but given an opportunity to do it, we should (again, IMO).
I completely agree with that, I didn't mean to imply we shouldn't, I was just documenting what the requirement was
Related Issue(s):
Proposed Changes:
PR Checklist: