stactools-packages / template

Template repository for stactools packages
Other
7 stars 7 forks source link

Rename script is overwriting the `stactools-packages` group name #24

Closed cuttlefish closed 3 years ago

cuttlefish commented 3 years ago

The rename script is mangling docker/env. sed implementation of regex doesn't support lookahead. This makes it difficult for it to recognize the difference between stactools-package and stactools-packages. The former should be rewritten, the latter should not. [I may be missing a simple option here]

As I see it we can:

gadomski commented 3 years ago

Could we do a really hackey "move out of the way" sort of thing, e.g.

  1. Change stactools-packages to stringthatwellchangebacklater
  2. Update all stactools-package
  3. Change stringthatwellchangbacklater to stactools-packages
cuttlefish commented 3 years ago

That's definitely an option 😆 I forgot to included it. I guess I'd rather change the package magic word, since it conflicts with other things as well. Neither solution is stellar, but I don't think anything more complex is warranted at the moment.

gadomski commented 3 years ago

I guess I'd rather change the package magic word, since it conflicts with other things as well.

Worksforme!

cuttlefish commented 3 years ago

👍 I'll take a look at it this afternoon