stactools-packages / template

Template repository for stactools packages
Other
7 stars 7 forks source link

mypy error on python 3.10.7+ #71

Closed wildintellect closed 1 year ago

wildintellect commented 1 year ago

Describe the bug A recent mypy bug leads to issues with python 3.10 When running mypy < 0.981 there's a bug that results in.

To reproduce Run pre-commit in a python 3.10.7+ environment

Expected behavior mypy should pass the same in all python versions used

Screenshots and shell session dumps ``mypy.....................................................................Failed

Additional context Offending line https://github.com/stactools-packages/template/blob/8b15971a9f1fae7933b0e45aac8d59188daf5db5/.pre-commit-config.yaml#L20

The easiest fix is to bump the mypy version specified in the .pre-commit-config.yaml. However @chuckwondo pointed out this means we have to keep tracking versions in the yaml instead of the same place as other parts of the project like requirements-dev.txt We'll put up a PR later today with a proposed fix.

gadomski commented 1 year ago

Fixed by #75.