stactools-packages / threedep

stactools package for working with elevation data from the USGS 3DEP program (formerly known as NED)
Other
3 stars 4 forks source link

Fix issue with `asset_ids` in `create-catalog` #15

Closed hrodmn closed 1 year ago

hrodmn commented 1 year ago

Related Issue(s): Resolves #14

Description: Rather than overwriting asset_ids variable when running the first collection, conditionally loop through asset_ids or utils.fetch_ids(product) to make sure you are not running asset_ids from one product on the other!

PR checklist:

hrodmn commented 1 year ago

Looks fine to me, the PR just needs to be updated with main to pick up #16, which I can't do b/c I don't have permissions on https://github.com/ncx-co/threedep.

I rebased my branch to get the latest changes, should be good to go now!

In the future, it can be easier if you create a branch on your fork for the PR -- that allows me to make minor fixup changes if needed.

Ah I see. So instead of pushing changes to main on my forked copy, just push changes to a branch and open a PR to the upstream repo?

gadomski commented 1 year ago

Ah I see. So instead of pushing changes to main on my forked copy, just push changes to a branch and open a PR to the upstream repo?

Yup, that makes it easier to (a) open multiple PRs from your fork, if you'd like to, and (b) repo maintainers (e.g. me) to push changed to your branch.