Closed hrodmn closed 1 year ago
Looks fine to me, the PR just needs to be updated with main to pick up #16, which I can't do b/c I don't have permissions on https://github.com/ncx-co/threedep.
I rebased my branch to get the latest changes, should be good to go now!
In the future, it can be easier if you create a branch on your fork for the PR -- that allows me to make minor fixup changes if needed.
Ah I see. So instead of pushing changes to main
on my forked copy, just push changes to a branch and open a PR to the upstream repo?
Ah I see. So instead of pushing changes to main on my forked copy, just push changes to a branch and open a PR to the upstream repo?
Yup, that makes it easier to (a) open multiple PRs from your fork, if you'd like to, and (b) repo maintainers (e.g. me) to push changed to your branch.
Related Issue(s): Resolves #14
Description: Rather than overwriting
asset_ids
variable when running the first collection, conditionally loop throughasset_ids
orutils.fetch_ids(product)
to make sure you are not runningasset_ids
from one product on the other!PR checklist:
scripts/format
).[ ] Code lints properly (run
scripts/lint
).stactools.core
, I think?scripts/test
).pytest
is passing, but not the linter that runs before it