stacythen / adam-ui

Library of reusable components
2 stars 0 forks source link

Waiting for ag-grid to update hooks #10

Open murugaratham opened 5 years ago

murugaratham commented 5 years ago

Currently getting deprecation notice, linking to ag-grid issues and wait for them to update

backend.js:1 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: AgGridReact

https://github.com/ag-grid/ag-grid/issues/3366

lgibso34 commented 5 years ago

same

sljidexcel commented 4 years ago

Hello,

I filed an official issue as well:

https://github.com/ag-grid/ag-grid/issues/3366

And received the following email response:

**Hi,

Thank you for your email. This is in our backlog now and we are tracking it with the following reference and description.

AG-3316 - agGridReact needs to be updated to use the updated react lifecycle hooks

You can follow the status of feature requests, bugs and releases using our pipeline:

https://www.ag-grid.com/ag-grid-pipeline/

(Note that newly raised issues can take up to 2 hours to appear in the pipeline)

Regards

Ahmed‍**

However, when I visit the pipeline, the search on AG-3316 yields nothing.

I do not understand how this ticket is closed when, looking at agGridReact in Github, the latest code seems to still have the deprecated function. Furthermore, given the problems with React 16.8.6:

https://github.com/facebook/react/issues/15970

The actual resolution of this ticket is really important.

Somebody, please provide some insight. Thank you | shade