search

stadelmanma / tree-sitter-fortran

Fortran grammar for tree-sitter
MIT License
30 stars 15 forks source link

Enhancements #58

Closed ghost closed 3 years ago

ghost commented 3 years ago
mrossinek commented 3 years ago

Hi @oponkork! I noticed this PR and I wanted to chime in since I have been using your queries since last November. I did apply these updates to them which you could consider useful, too: https://gitlab.com/mrossinek/dotfiles/-/commit/433ff9fb8ad54ab98c6b3a8f5a0fcf1f0ae0452c

ghost commented 3 years ago

@mrossinek Thanks a lot for finding the missing keywords. I have been adding keywords by looking at my own source files but fortran has so many of them.

I have also added indents.scm and folding.scm, can you test if it works for you?

mrossinek commented 3 years ago

I have also added indents.scm and folding.scm, can you test if it works for you?

folds.scm is identical to the one I use currently so it should be working as expected :+1: I will gladly look into indents.scm, too, but it might take me a while so don't have this halt the PR in any way :+1:

stadelmanma commented 3 years ago

Also @oponkork I'm getting this error in CI and when I try to run npm test locally. 

mstadelman:Development/tree-sitter-fortran(oponkork-master)S?➜ npm test                                          [0 6.0G 0.00%] 18:32:38

> tree-sitter-fortran@0.0.1 test /home/mstadelman/Development/tree-sitter-fortran
> tree-sitter test && tree-sitter parse examples/* --quiet --time

Incompatible language version 13. Expected minimum 9, maximum 12
npm ERR! Test failed.  See above for more details.

I bumped the tree-sitter-cli version to 0.19.4 to fix it.

stadelmanma commented 3 years ago

Thanks @oponkork!