search

stadelmanma / tree-sitter-fortran

Fortran grammar for tree-sitter
MIT License
30 stars 15 forks source link

Improvements, mostly for object-oriented programming in fortran. #72

Closed navdeeprana closed 1 year ago

navdeeprana commented 1 year ago
navdeeprana commented 1 year ago

@stadelmanma Could you kindly have a look at the PR?

ZedThree commented 1 year ago

@stadelmanma @navdeeprana I've had a look at this and it looks good. I've added a few tests and fixed some issues with select type.

Would you prefer I open a PR into this one, or make an entirely new PR that includes this branch?

stadelmanma commented 1 year ago

@ZedThree I'm fine with just building on top of this PR. @navdeeprana could we add some tests for the new statements & logic added?

navdeeprana commented 1 year ago

@ZedThree I'm fine with just building on top of this PR. @navdeeprana could we add some tests for the new statements & logic added?

@ZedThree, I see you have opened a new PR #74 with tests, do they exhaust all the changes for this PR?

ZedThree commented 1 year ago

Yep, #74 should test all of the features added here, except open/close and stop, as they looked to already have tests.

On Sun, 12 Feb 2023, 14:22 Navdeep Rana, @.***> wrote:

@ZedThree https://github.com/ZedThree I'm fine with just building on top of this PR. @navdeeprana https://github.com/navdeeprana could we add some tests for the new statements & logic added?

@ZedThree https://github.com/ZedThree, I see you have opened a new PR

74 https://github.com/stadelmanma/tree-sitter-fortran/pull/74 with

tests, do they exhaust all the changes for this PR?

— Reply to this email directly, view it on GitHub https://github.com/stadelmanma/tree-sitter-fortran/pull/72#issuecomment-1427045945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLAXRUD4AUY33VOEVS6VLWXDWZLANCNFSM6AAAAAAT3GR434 . You are receiving this because you were mentioned.Message ID: @.***>

stadelmanma commented 1 year ago

Closing in favor of #74