search

stadelmanma / tree-sitter-fortran

Fortran grammar for tree-sitter
MIT License
30 stars 15 forks source link

Fix usage of hidden external node #94

Closed amaanq closed 1 month ago

amaanq commented 2 months ago

Tree-sitter has had an update where hidden nodes consisting of just one terminal do not have the "absorption" feature that is silently present that you might have noticed. The problem is, with hidden nodes, this absorption does not allow the literal to be queried for, which was a pain point that was subtle but potentially inexplicable behavior. As such, we should just not have a node for this if we are concerned with a literal that is an anonymous node that is also an external - we can just directly reference this anonymous node if we want to hide it from the parse tree anyways (but still allow it to be queryable)

clason commented 1 month ago

@stadelmanma the description does not make it clear, but without this change, generating the tree-sitter-fortran parser will FAIL on tree-sitter master (and thus the upcoming release).

stadelmanma commented 1 month ago

Just looked up and read through the relevant PR on the main repo that prompted this change. Thanks for this!