A bit of linting - Githubissues

stadiamaps / ferrostar

A FOSS navigation SDK built from the ground up for the future

https://stadiamaps.github.io/ferrostar/

Other

91 stars 10 forks source link

A bit of linting #107

Closed nyurik closed 1 month ago

nyurik commented 1 month ago

unpublished crates should not have version, and should have publish=false
add clippy lints to workspace
worked through a number of clippy suggestions

ianthetechie commented 1 month ago

Looks like we need to bump the MSRV (seems like 1.75 added support for version-less packages): https://github.com/rust-lang/cargo/pull/12786

ianthetechie commented 1 month ago

Just an FYI for next time: even changes to comments in the generated bindings result in UniFFI's pedantic integrity checksums failing ;) Normally one would simply not commit generated bindings, but regrettably I haven't yet figured out a way to avoid this given the... quirks of how SPM works. Android doesn't have this problem.

So, TL;DR, you'll need to run build-ios.sh in the common directory before committing and stage any changes in ferrostar.swift.