search

stadiamaps / ferrostar

A FOSS navigation SDK built from the ground up for the future
https://stadiamaps.github.io/ferrostar/
Other
180 stars 25 forks source link

[ios] pull down InstructionView handle to show remaining steps #276

Closed michaelkirk closed 1 month ago

michaelkirk commented 1 month ago

FIXES #32

https://github.com/user-attachments/assets/ef3f3f2d-921e-457a-8307-73dff466dce5

https://github.com/user-attachments/assets/002a5665-e1d6-4801-bbe0-af6a48c4afde

michaelkirk commented 1 month ago

Converting to a draft, I'd like to tweak the handle styling slightly and add a snapshot test for the expanded maneuver list.

michaelkirk commented 1 month ago

Ok! I applied a couple last style tweaks, and updated the demo videos in the description.

michaelkirk commented 1 month ago

I think that we can sidestep the problem by making this a binding instead of a boolean value. This way developers can still do what you intended, but with less potential confusion and more flexibility:

Funny enough, I actually had it as a binding initially, but got annoyed at not being able to fiddle with the canvas Previews, and decided to change it.

But really, exposing the "isExpanded" parameter was all just a last minute thing I added to enable snapshot tests, so I'm pretty happy to go whatever way you prefer with it.

(Side note: it's clear that you understand what's happening since your comment explains that this is only the initial value, but I think that puts you in the top like 2% of devs by SwiftUI knowledge :D)

Thank you, but this is a miscalculation on your part. 😆 I'm new to SwiftUI and any apparent competence is purely coincidental. I'm almost constantly confounded by it.

michaelkirk commented 1 month ago

There are a few conflicts unfortunately with the main branch since @Archdoog just cleaned up a bunch of stuff to clean up the pattern matching mess 😅

I have rebased and pushed.

If this is not a rebase and force push kind of town, let me know, and I will merge with main next time.

ianthetechie commented 1 month ago

Thanks! Giving it a final check now!

I'm almost constantly confounded by it.

ha! Yeah, SwiftUI is... pretty confounding. I found Thinking in SwiftUI helpful for making it SLIGHTLY less confounding... (No joke, I read the sections on state management like 25 times over while doing the initial sketches of the MapLibre SwiftUI DSL.)

If this is not a rebase and force push kind of town, let me know, and I will merge with main next time.

All good; thanks for checking 👍